DDC-2965 - Changing ID generation after flush makes persisters unusable
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2966 We use Jira to track the state of pull requests and the versions they got |
| @@ -2383,7 +2383,8 @@ public function clear($entityName = null) | |||
| $this->extraUpdates = | |||
| $this->readOnlyObjects = | |||
| $this->visitedCollections = | |||
| $this->orphanRemovals = array(); | |||
| $this->orphanRemovals = | |||
| $this->persisters = array(); | |||
There was a problem hiding this comment.
@psliwa can you look into this? Basically, my idea is that changing metadata after initialization can lead to very unexpected results, and therefore requires either a new EntityManager instance or clearing it.
|
It is not officially supported to change the metadata after usage. These objects are frozen after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As posted on http://www.doctrine-project.org/jira/browse/DDC-2965 by @psliwa (imported his tests)