Update phpstan to 0.10.8 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
force-pushed
the
phpstan
branch
2 times, most recently
from
44bc8c8
to
7945112
Compare
jwage
approved these changes
Jan 9, 2019
Majkl578
reviewed
Jan 9, 2019
| @@ -37,7 +37,7 @@ public function __construct(WordInflector $singularizer, WordInflector $pluraliz | |||
| */ | |||
| public function tableize(string $word) : string | |||
| { | |||
| return mb_strtolower(preg_replace('~(?<=\\w)([A-Z])~u', '_$1', $word)); | |||
| return mb_strtolower((string) preg_replace('~(?<=\\w)([A-Z])~u', '_$1', $word)); | |||
There was a problem hiding this comment.
These changes are not valid, it hides the error instead of reacting on it.
There was a problem hiding this comment.
I started to throw exceptions when preg_replace returns null but it got so complicated so quick in some areas where we chain multiple preg_replace calls together. I'll work on it in #115
There was a problem hiding this comment.
Also, do you know in what scenarios preg_replace would return null?
There was a problem hiding this comment.
There was a problem hiding this comment.
There is also https://github.com/thecodingmachine/safe not related, bad thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed
leveltomaxin configuration.