Fix plural of media breaking change #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2020
patrickbrouwers
force-pushed
the
fix-media-plural-breaking-change
branch
from
1ed2815
to
9597824
Compare
Add tests for plural of media
patrickbrouwers
force-pushed
the
fix-media-plural-breaking-change
branch
from
9597824
to
b4d1151
Compare
|
Thanks @patrickbrouwers! |
|
Hi @alcaeus, when is this being tagged / released? |
This was referenced May 11, 2020
|
We'll have a release out later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 1.3 of inflector, the plural of media was
media(which is correct, media is already the plural of medium). When updating to 1.4 the plural becamemedias, which I believe is incorrect but also a breaking change.1.3.1:
1.4.0:
Related issue that was caused by this change: spatie/laravel-medialibrary#1864
Possible related PR: #125