Fix handling of multiple rulesets #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the Travis failures new? |
|
Yeah, will work on them later today before finishing up. Should’ve tested everything locally 😅 |
alcaeus
force-pushed
the
fix-multiple-rule-application
branch
from
11f132b
to
26b4e12
Compare
|
Fixed tests. The removed test is obsolete and is covered with the new test. The test I updated failed due to the mocks needing updating - turns out it's easier to not update them but use actual rules. |
SenseException
approved these changes
May 28, 2020
greg0ire
approved these changes
May 29, 2020
|
Thanks @alcaeus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where applying a custom inflection of a word that was on the "uninflected" list of another ruleset was not being applied. This allows people to override newly uninflected words such as "travel", "homework", "research", and potentially more.