Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero works the same as Buffalo and Tomato #18

Merged
merged 2 commits into from Jul 7, 2015

Conversation

Projects
None yet
2 participants
@bingvanmoorsel
Copy link
Contributor

commented Jul 7, 2015

Im using the word Hero, right now its beeing transformed to: Heros

Regards,
Bing

Hero works the same as Buffalo and Tomato
Im using the word Hero, right now its beeing transformed to: Heros

Regards,
Bing
@guilhermeblanco

This comment has been minimized.

Copy link
Member

commented Jul 7, 2015

@bingvanmoorsel can you add a test covering this scenario to the test suite, please?

added test coverage
added hero => heroes
@bingvanmoorsel

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2015

I added the test as you requested.

The test was succesfull, but travis had an error. check the details...

@guilhermeblanco

This comment has been minimized.

Copy link
Member

commented Jul 7, 2015

@bingvanmoorsel thanks a lot! =)

guilhermeblanco added a commit that referenced this pull request Jul 7, 2015

Merge pull request #18 from bingvanmoorsel/patch-1
Hero works the same as Buffalo and Tomato

@guilhermeblanco guilhermeblanco merged commit aa889f1 into doctrine:master Jul 7, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@guilhermeblanco guilhermeblanco self-assigned this Nov 6, 2015

@guilhermeblanco guilhermeblanco added this to the v1.1.0 milestone Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.