add 'epoch' to irregular words list

[kyosheek]

Add irregular word 'epoch' to list. Reference: https://www.britannica.com/dictionary/epoch

[greg0ire]

@kyosheek thanks for this. What was the behavior before your fix?

Cc @driesvints

[kyosheek]

@greg0ire it was according to grammar rules I suppose (I am not native speaker :d), epoch -> epoches, like with witch/witches, watch/watches etc.

[greg0ire]

I suppose

What do you mean? You haven't seen an actual bug? How did you spot the issue?

[kyosheek]

I mean that pluralizes acts according to grammar rules, but the epoch word is exception in this case, sorry for the confusion.

The bug appeared in our production code while using Laravel's helper function for pluralizing, Str::plural() to be exact.

[greg0ire]

Oh I wasn't confused about the issue was, but about how you noticed it. Thanks for clarifying that.

[SenseException]

✅ if we still add this change to the next patch release.

Is the failed bc check somehow relevant to the change?

[greg0ire]

No, it has to do with Nyholm/roave-bc-check-docker#32

[derrabus]

That case should be added to EnglishFunctionalTest as well.

[pimjansen]

No, it has to do with Nyholm/roave-bc-check-docker#32

Same my last reply on the issue there!

[greg0ire]

Thanks @kyosheek !