Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pluralization of axis #241

Merged
merged 1 commit into from Jan 15, 2024
Merged

Correct pluralization of axis #241

merged 1 commit into from Jan 15, 2024

Conversation

iurciuc
Copy link

@iurciuc iurciuc commented Jan 12, 2024

@malarzm
Copy link
Member

malarzm commented Jan 12, 2024

@iurciuc thanks for your PR! I'm afraid we have a hard nut to crack here as per the tests: axes was previously singularized to axe and after your change no longer is. I can't really see a way forward as fixing your bug means breaking something that worked before :/

@malarzm
Copy link
Member

malarzm commented Jan 12, 2024

Theoretically we could fix axis -> axes and still have axes -> axe as the lib has no way of knowing what word it should singularize into. Thoughts?

@iurciuc
Copy link
Author

iurciuc commented Jan 13, 2024

In 99% of cases axes->axe will be what user expected!
To be consistent(English in this case is not so consistent) we can build a feature to provide possibility to extend the logic of this lib by a config.

@malarzm
Copy link
Member

malarzm commented Jan 13, 2024

I think config is an overkill in this case :) Let's proceed with fixing axis -> axes but keeping axes -> axe

@iurciuc
Copy link
Author

iurciuc commented Jan 15, 2024

Fixed

@malarzm malarzm added this to the 2.0.9 milestone Jan 15, 2024
@malarzm malarzm merged commit 2930cd5 into doctrine:2.0.x Jan 15, 2024
12 checks passed
@malarzm
Copy link
Member

malarzm commented Jan 15, 2024

Thanks @iurciuc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants