Singularize regattas to regatta instead of regattum

[discern]

While using Laravel Shift's Blueprint, I encountered an issue with the word "regatta" not being inflected properly (the singularizer was changing the plural from "regattas" to "regattum"). The updated pattern should solve it in this case. I added a few other words to the test, as well.

[malarzm]

Given you're fixing one word only I think it'd be better to put this into irregular list here. New tests will be great addition though!

inflector/lib/Doctrine/Inflector/Rules/English/Inflectible.php

Line 93 in 2930cd5

public static function getIrregular(): iterable

[discern]

That was the first thing I tried, but it only worked in one direction. With yield new Substitution(new Word('regatta'), new Word('regattas')); in the irregular list, Str::singular('regatta') produces "regattum", and with yield new Substitution(new Word('regattas'), new Word('regatta'));, Str::singular('regatta') produces "regattas." For that reason I used a negative look-behind in the getSingular() regex. Open to other suggestions.

[malarzm]

Str::singular('regatta') produces "regattum"

That's not a blocker, we do not support singularizing words which are already singular :)

[discern]

I think perhaps the inflector is assuming that "regatta" is plural, due to the -ta ending. Besides, shouldn't it just return the original word if it wasn't inflectible in the requested direction?

I added these two assertion arguments to dataSingularsUninflectedWhenSingularized().

['regatta', 'regattum'],
['regattas', 'regattum'],

---

Without changing the rules, and with the added assertions:

'regatta' should not be singularized to 'regattum'

---

By adding this to getIrregular():

getIrregular()
    yield new Substitution(new Word('regatta'), new Word('regattas'));
...
'regatta' should not be singularized to 'regattum'

---

(Oddly, by reversing these arguments, the tests pass. But this makes no sense, and Blueprint fails anyway.)

---

By changing the regex, the tests pass and Blueprint builds the table and class names correctly:

getSingular()
    yield new Transformation(new Pattern('([ti])a(?<!regatta)$'), '\1um');

But then we'd be changing a regex for a rarely used word, which has been deemed suboptimal.

Again, if you have a better idea, I'm all ears. Otherwise, I guess I'll use my fork.

[malarzm]

Thanks for all the tinkering and explanations! I wanted to make sure we're not introducing regexes without a good reason. So without further ado :)