Words with no singular #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwells could you rebase on top of master to fix build failures? Also, you should add the words to the test to protect against regressions. Thanks! |
mattwells
force-pushed
the
patch-1
branch
2 times, most recently
from
98da847
to
a167bed
Compare
|
@alcaeus I have done as request, please let me know if there is anything else :) |
alcaeus
reviewed
Jun 16, 2017
| 'people', | ||
| 'cookie', | ||
| 'police', | ||
| 'cloths', |
There was a problem hiding this comment.
Is this supposed to be cloths or a typo of clothes?
There was a problem hiding this comment.
You are quite right, sorry about that, fixed the issue.
alcaeus
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following words that are both singular and plural:
The other items in the
uninflectedarray have a wildcard prefix, I don't believe it is need with these words so I haven't included it. Please correct me if I am wrong.