Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple languages. #97

Merged
merged 6 commits into from
Jun 29, 2018
Merged

Add support for multiple languages. #97

merged 6 commits into from
Jun 29, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented Jun 26, 2018

Fixes #94
Fixes #57

@jwage jwage added this to the v2.0.0 milestone Jun 26, 2018
@jwage jwage force-pushed the more-refactoring branch 21 times, most recently from 0c9cae7 to 10b8521 Compare June 29, 2018 03:04
@jwage jwage changed the title More refactoring of factories and rules. Add support for multiple languages. Jun 29, 2018
@jwage jwage force-pushed the more-refactoring branch 2 times, most recently from 34af5cf to 950de97 Compare June 29, 2018 16:07
@dmecke
Copy link

dmecke commented Jun 29, 2018

How to start with a new language? I'd like to add german, but don't know how to start. Translate and adjust the english rules? Get the rules from another source?

@jwage
Copy link
Member Author

jwage commented Jun 29, 2018

@dmecke you can look at the other languages to see how the rules are defined. Then you can implement the rules.

@jwage jwage merged commit 9f50f4c into master Jun 29, 2018
@jwage jwage deleted the more-refactoring branch June 29, 2018 18:52
@jwage jwage mentioned this pull request Jun 29, 2018
@alcaeus alcaeus modified the milestones: 2.0.0, 1.4.0 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor InflectorFactory Other language inflector
3 participants