Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated migration classes should be final #582

Closed
soullivaneuh opened this issue Dec 13, 2017 · 0 comments
Closed

Generated migration classes should be final #582

soullivaneuh opened this issue Dec 13, 2017 · 0 comments
Assignees
@lcobucci
Labels
Improvement
Milestone
1.7

Comments

@soullivaneuh
Copy link
Contributor

Because there is no reason to extend a migration class AFAIK.

https://ocramius.github.io/blog/when-to-declare-classes-final/
@soullivaneuh soullivaneuh changed the title Generated migration class should be final Generated migration classes should be final Dec 13, 2017
@soullivaneuh soullivaneuh mentioned this issue Dec 13, 2017
Merged
lcobucci added a commit that referenced this issue Dec 13, 2017
@lcobucci
Merge pull request #583 from Soullivaneuh/final-version-class
558dac3 
Make version class final

Fixes #582
@lcobucci lcobucci self-assigned this Dec 13, 2017
@lcobucci lcobucci added this to the 1.7 milestone Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcobucci lcobucci

Labels
Improvement
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
2 participants
@lcobucci @soullivaneuh