Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed out-of-date lock file #1008

Merged
merged 1 commit into from Jun 20, 2020
Merged

Fixed out-of-date lock file #1008

merged 1 commit into from Jun 20, 2020

Conversation

bobvandevijver
Copy link
Contributor

Q A
Type improvement
BC Break no

Summary

The lock was not updated in b9469d3. Gave me an error when building some other improvements.

@greg0ire
Copy link
Member

Is master the lowest branch where this change is relevant?

@bobvandevijver
Copy link
Contributor Author

Is master the lowest branch where this change is relevant?

Looking at the commit that caused this, I do believe so. I also checked 3.0.x, which doesn't have an outdated lock file.

@greg0ire greg0ire closed this Jun 20, 2020
@greg0ire greg0ire reopened this Jun 20, 2020
goetas
goetas approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it went out of date on master when I have increased the branch aliase

@greg0ire greg0ire merged commit 1db639c into doctrine:master Jun 20, 2020
@bobvandevijver bobvandevijver deleted the update-lock branch June 20, 2020 12:54
@goetas goetas added this to the 3.1.0 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@goetas goetas goetas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvandevijver @greg0ire @goetas