Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note BC Break in migrations template #1033

Merged
merged 1 commit into from Jul 9, 2020
Merged

Note BC Break in migrations template #1033

merged 1 commit into from Jul 9, 2020

Conversation

havvg
Copy link
Contributor

@havvg havvg commented Jul 7, 2020 •
edited

Q A
Type Documentation
BC Break No.

SenseException
SenseException requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target your PR to the 3.0.x branch, because this change was introduced in 3.0.

@greg0ire greg0ire changed the base branch from master to 3.0.x July 7, 2020 20:14
@greg0ire
Copy link
Member

greg0ire commented Jul 7, 2020

Please target your PR to the 3.0.x branch, because this change was introduced in 3.0.

I did it for you @havvg :)

@greg0ire greg0ire requested a review from goetas July 8, 2020 21:19
@goetas goetas added this to the 3.0.2 milestone Jul 9, 2020
@goetas goetas merged commit 2d45b78 into doctrine:3.0.x Jul 9, 2020
@goetas
Copy link
Member

goetas commented Jul 9, 2020

Thank you!

@github-actions github-actions bot mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@goetas goetas Awaiting requested review from goetas

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@havvg @greg0ire @goetas @SenseException