Check PHP_OS_FAMILY for Windows in Tests #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguitarguy
force-pushed
the
issue-1037
branch
from
2589cc6
to
3678e11
Compare
goetas
approved these changes
Jul 13, 2020
Instead of checking `PHP_OS` for `Win`. The old version was matching `Darwin` on OSX and causing a false negative. Fixes doctrine#1037
greg0ire
force-pushed
the
issue-1037
branch
2 times, most recently
from
da4ce93
to
419acbd
Compare
greg0ire
approved these changes
Jul 22, 2020
|
Thanks @chrisguitarguy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of checking
PHP_OSforWin. The old version was matchingDarwinon OSX and causing a false negative.