Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code sample in custom integrations docs page #1051

Merged
merged 2 commits into from Aug 29, 2020
Merged

Fix code sample in custom integrations docs page #1051

merged 2 commits into from Aug 29, 2020

Conversation

pawel-lewtak
Copy link
Contributor

@pawel-lewtak pawel-lewtak commented Aug 28, 2020 •
edited

Q A
Type bug
BC Break no
Fixed issues

Summary

Fix wrong namespace and variable in docs for custom integrations. Provided code sample wouldn't work otherwise.

@pawel-lewtak pawel-lewtak changed the title Fix namespace for loading PhpFile class in docs Fix code sample in custom integrations docs page Aug 28, 2020
@goetas goetas merged commit 4eef7b0 into doctrine:3.0.x Aug 29, 2020
@goetas
Copy link
Member

goetas commented Aug 29, 2020

Thanks

@goetas goetas added this to the 3.0.2 milestone Oct 20, 2020
@github-actions github-actions bot mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawel-lewtak @goetas