Readme badges improvements #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis was abandoned.
It makes no sense to link to information about another branch.
|
Not sure yet why codecov says we have 0% coverage in the badge 😅 |
goetas
approved these changes
Nov 28, 2020
stof
reviewed
Nov 30, 2020
| [](https://packagist.org/packages/doctrine/migrations) | ||
| [](https://packagist.org/packages/doctrine/migrations) | ||
| [](https://github.com/doctrine/migrations/blob/3.1.x/LICENSE) | ||
| [](https://github.com/doctrine/migrations/blob/3.0.x/LICENSE) |
There was a problem hiding this comment.
you could use a relative link (LICENSE) here. Github will resolve it (and Packagist too), and that will avoid having to update it in each branch.
stof
reviewed
Nov 30, 2020
| @@ -1,10 +1,10 @@ | |||
| # Doctrine Migrations | |||
|
|
|||
| [](https://travis-ci.org/doctrine/migrations) | |||
| [](https://codecov.io/gh/doctrine/migrations/branch/3.1.x) | |||
| [](https://github.com/doctrine/migrations/actions) | |||
There was a problem hiding this comment.
the label parameter does not exist in the github actions badge URL
|
@stof thanks, addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.