Allow psr/log 2 and 3
#1184
Allow psr/log 2 and 3
#1184
Conversation
derrabus
commented
Jul 18, 2021
derrabus
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
| Fixed issues | N/A |
|
The build is still using |
Yes, because your CI tests against stable packages only. You can try this out locally by allowing a dev version of |
|
Looks like waiting for the next patch version of Symfony would be enough to be sure it actually works: symfony/symfony#42174 Let's do that? |
|
Sure, there's no need to rush anything, I guess. |
This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [ci] handle new 5.4 branch & make dev tests green - We don't have a `5.x` branch anymore on `symfony/symfony` - let's use the `dev` version specified in `versions.json` in place of the `5.x` branch. - `SYMFONY_REQUIRE` env param in CI overrides the stability version specified for the run, resulting in a mixed set of versioned packages for each test. e.g. `symfony/http === v5.3.0` && `symfony/twig-bridge === v5.4.x-dev` even though `SYMFONY_SKELETON_STABILITY=dev` is set. - some symfony components now use `psr/log` `^1 || ^2 || ^3` but `doctrine/migrations` still uses `^1`. For migrations tests, because `doctrine/orm` is required after the skeleton has been built, there is a version conflict w/ the locked, `psr/log:2.0` and `doctrine/migrations`. Calling `psr/log:^1.1.4` resolves this issue and allows the tests to run. _contains ``@legacy`` tags for internal use:_ - Remove `psr/log:^1.1.4` as extraDependency in `MakeMigrationsTest` once doctrine/migrations#1184 is merged, tagged, and released. Commits ------- e6b691f [ci] handle new 5.4 branch & make dev tests green
|
The PHPUnit job on PHP 8.0 passes with |
|
@greg0ire since this is marked as improvement, shouldn't target |
|
I'm not familiar with the process here, sorry. Shall I relabel it as a bugfix? I don't think that simply widening the version range of a dependency really requires a minor version bump. |
|
It's more about stability than anything else: huge changes in the tests directory could go to the stable branch. If @derrabus says this change is not a big deal, then I think it's fine to merge it here. |
|
Thanks @derrabus! |
