PHPStan 1.5, Doctrine Coding Standard 9 #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Mar 31, 2022
| @@ -35,6 +37,11 @@ parameters: | |||
| paths: | |||
| - tests/Doctrine/Migrations/Tests/Generator/ClassNameGeneratorTest.php | |||
|
|
|||
| # TODO: Be more precise about class-strings | |||
There was a problem hiding this comment.
I tried to fix this one error, but it's really a rabbit hole. Someone (maybe me) could work on a fix this on a dedicated PR. For now, it should be fine to ignore the error.
| @@ -15,7 +15,7 @@ | |||
| */ | |||
| final class CurrentCommand extends DoctrineCommand | |||
| { | |||
| /** @var string */ | |||
| /** @var string|null */ | |||
There was a problem hiding this comment.
Because they are in the parent class and types of overridden properties have to be invariant.
greg0ire
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps PHPStan and its plugins and fixes newly discovered errors.