Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage getNativeConnection() when checking the transaction state #1249

Merged
merged 2 commits into from Mar 31, 2022

Conversation

dmaicher
Copy link
Contributor

Q A
Type bug
BC Break no
Fixed issues #1247

Summary

Fixes #1247 by using getNativeConnection

@dmaicher dmaicher marked this pull request as ready for review March 31, 2022 13:58
@dmaicher dmaicher requested a review from derrabus March 31, 2022 13:59
phpstan-dbal-3.neon.dist Outdated Show resolved Hide resolved
@derrabus derrabus added the Bug label Mar 31, 2022
@derrabus derrabus added this to the 3.4.2 milestone Mar 31, 2022
@derrabus derrabus changed the title fix issue 1247 by using getNativeConnection Leverage getNativeConnection() when checking the transaction state Mar 31, 2022
@derrabus derrabus merged commit be5d46d into doctrine:3.4.x Mar 31, 2022
@derrabus
Copy link
Member

Thank you @dmaicher!

@peter17
Copy link

peter17 commented Apr 3, 2022

Thanks! Any chance that a 3.4.2 tag could be created to make this fix more available, please? Thanks again!

@derrabus
Copy link
Member

derrabus commented Apr 4, 2022

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when using DBAL middlewares
3 participants