Drop support for DBAL 2, PHP 7.2, Symfony 3, Persistence 1 #1250
Conversation
| } | ||
| try { | ||
| return $connection->getNativeConnection(); | ||
| } catch (LogicException $e) { | ||
| } | ||
|
|
||
| $innermostConnection = $connection; |
There was a problem hiding this comment.
Todo: check if the code below is still useful
There was a problem hiding this comment.
From what I understood, it will be useful until DBAL 4, when we are sure that getNativeConnection can no longer throw a LogicException.
greg0ire
force-pushed
the
drop-dbal2
branch
2 times, most recently
from
1eb6790
to
e1d1da5
Compare
| @@ -13,7 +13,6 @@ cache: | |||
|
|
|||
| environment: | |||
| matrix: | |||
| - php: 7.2.25 | |||
There was a problem hiding this comment.
Todo: determine what our policy for testing on appveyor shall be
This comment was marked as resolved.
This comment was marked as resolved.
greg0ire
changed the title
greg0ire
force-pushed
the
drop-dbal2
branch
2 times, most recently
from
8375ba4
to
beea147
Compare
| "symfony/cache": "^3.4.26 || ^4.2.12 || ^5.0 || ^6.0", | ||
| "symfony/process": "^3.4 || ^4.0 || ^5.0 || ^6.0", | ||
| "symfony/yaml": "^3.4 || ^4.0 || ^5.0 || ^6.0" | ||
| "phpunit/phpunit": "^9.4", |
There was a problem hiding this comment.
| "phpunit/phpunit": "^9.4", | |
| "phpunit/phpunit": "^9.5", |
PHPUnit 9.4 is dead and buried.
|
|
||
| <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint"> | ||
| <exclude-pattern>*/lib/*</exclude-pattern> | ||
| </rule> |
There was a problem hiding this comment.
Maybe I should remove those, git add --patch the parts that are backwards compatible, and restore these lines. But that would probably be best in a separate PR for the sake of review.
There was a problem hiding this comment.
Just tried it, and it's not that complicated to untangle, I'll push it as an extra commit.
greg0ire
force-pushed
the
drop-dbal2
branch
3 times, most recently
from
2a8685e
to
8da97d4
Compare
|
I think that the 2 issues reported by the BC check can be safely ignored. |
DBAL 3 requires PHP 7.3
This includes: - private properties - public properties of final classes protected properties must have the same type or lack thereof as their parent.
DBAL 2 will no longer be supported tomorrow, and DBAL 3 requires PHP 7.3