Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added success message for Command Output #1303

Merged
merged 1 commit into from Jan 12, 2023

Conversation

cpats007
Copy link

  • Added success message before new line for successful migrations
  • updated unit tests
Q A
Type improvement
BC Break no
Fixed issues none

Summary

When executing a successful migration, the only output from the command when not using verbosity levels is a blank new line. When running from something like ansible, it's sometimes nice to see an output. This PR adds a single line output to denote a successful migration to version XXX

Examples:

Previously you would need to run the migration twice to ensure that the update was successful:

image

This is how it will look on first run with the new change:

image

- Added success message before new line for successful migrations
- updated unit tests
@SenseException
Copy link
Member

Failed BC check looks unrelated.

@greg0ire greg0ire added this to the 3.6.0 milestone Jan 12, 2023
@greg0ire greg0ire merged commit f8fe749 into doctrine:3.6.x Jan 12, 2023
@greg0ire
Copy link
Member

Thanks @cpats007 !

@cpats007
Copy link
Author

Thanks @cpats007 !

No problem, thanks for merging :)

@cpats007 cpats007 deleted the command-success-message branch January 17, 2023 08:17
@ToshY
Copy link
Contributor

ToshY commented Feb 15, 2023

As pedantic as this may sound, a colon is never preceded by a white space in the English language.

@greg0ire
Copy link
Member

At the risk of sounding even more pedantic, you should never use bold if you intend the text you write to be read linearly.

@ToshY
Copy link
Contributor

ToshY commented Feb 16, 2023

At the risk of sounding even more pedantic, you should never use bold if you intend the text you write to be read linearly.

Duly noted.

Back to the issue at hand: space preceding a colon. I assume there are no objections to fixing it then.

@greg0ire
Copy link
Member

No objections. If you want to send a PR, you might want to run grep -rn -F ' :' to look for other violations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants