Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/deprecations 1.0 #1358

Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 7, 2023

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

3.4.x is the last branch that still supports DBAL 2. Unfortunately, it does not allow the installation of Deprecations 1.0 although there haven't been breaking changes between 0.5 and 1.0. This in turn blocks upgrading to recent versions of the ORM.

It would make the upgrade path for projects that are still on DBAL 2 a lot easier if we pushed a new 3.4.x tag that allows doctrine/deprecations 1.x.

@derrabus derrabus merged commit 362f07f into doctrine:3.4.x Sep 7, 2023
6 of 18 checks passed
@derrabus derrabus deleted the improvement/deprecations-1-on-3.4 branch September 7, 2023 12:23
@derrabus derrabus added this to the 3.4.3 milestone Sep 7, 2023
derrabus added a commit that referenced this pull request Sep 7, 2023
* 3.4.x:
  Allow doctrine/deprecations 1.0 (#1358)
derrabus added a commit that referenced this pull request Sep 7, 2023
* 3.5.x:
  Allow doctrine/deprecations 1.0 (#1358)
derrabus added a commit that referenced this pull request Sep 7, 2023
* 3.6.x:
  Allow doctrine/deprecations 1.0 (#1358)
derrabus added a commit to derrabus/migrations that referenced this pull request Sep 7, 2023
* 3.7.x: (21 commits)
  Allow doctrine/deprecations 1.0 (doctrine#1358)
  Drop support for Symfony 4 (doctrine#1352)
  Modernize codebase for PHP 8 (doctrine#1351)
  Remove docs from the archives (doctrine#1356)
  Ditch action in favor of running tool directly (doctrine#1354)
  Fix PHPStan errors after PHPUnit update (doctrine#1350)
  Add sh to .gitattributes
  Update .gitattributes
  Avoid complex mock building
  Migrate to PHPUnit 10
  Make data providers static
  Remove unneeded phpcs rule
  Suffix abstract test class with TestCase
  Add details to sync-metadata-storage's help
  Update coding standard to v12
  Remove ignore rule for @method-provided method
  build: Use the new compactors
  build: Fix cleanup of the backup composer lock file
  Add attributes to commands
  removed preceding whitespace in front of colons
  ...
@mhsdesign
Copy link

THANK YOU SO MUCH FOR THIS ;)

I just noticed this in a composer update ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants