Fix formatParameter() for floats #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Nov 17, 2023
derrabus
commented
| Q | A |
|---|---|
| Type | bug |
| BC Break | no |
| Fixed issues | Fix #1373 |
SenseException
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
You already asked it in the issue, but I'd also like to know if this will fix @BigMichi1's problem.
Comment on lines
+75
to
76
| if (is_int($value) || is_string($value) || is_float($value)) { | ||
| return (string) $value; |
There was a problem hiding this comment.
Why did a string value need a string type cast?
There was a problem hiding this comment.
It doesn't, it's a cheap no-op. I suppose the original author simply wanted to keep the code short.
|
For me this works now |
greg0ire
approved these changes
Nov 18, 2023
derrabus
added a commit
that referenced
this pull request
Nov 19, 2023
* 3.8.x: Fix formatParameter() for floats (#1374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.