Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exception classes into separate directory #303

Closed
wants to merge 1 commit into from
Closed

Move exception classes into separate directory #303

wants to merge 1 commit into from

Conversation

neeckeloo
Copy link
Contributor

No description provided.

@stof
Copy link
Member

stof commented Jun 29, 2015

This is a BC break (it will break any existing generated migration using them, and any code catching them).

So -1 for this.

@neeckeloo
Copy link
Contributor Author

The change in 0e60856 left me thinking we could afford to break compatibility in alpha releases.

@stof
Copy link
Member

stof commented Jun 29, 2015

Well, the change in 0e60856 only impacts people using an unmaintained PHP version.

This change will impact everyone using the library. and people are using it in production since years, even though we never released it in non-alpha. So IMO, we should already care about BC (and we should release it as stable IMO)

@neeckeloo
Copy link
Contributor Author

I understand and this is not an essential change either.

@neeckeloo neeckeloo closed this Jun 29, 2015
@neeckeloo neeckeloo deleted the feature/move-exceptions branch June 29, 2015 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants