Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SQL file writer #305

Merged
merged 2 commits into from
Jun 29, 2015
Merged

Refactoring SQL file writer #305

merged 2 commits into from
Jun 29, 2015

Conversation

neeckeloo
Copy link
Contributor

No description provided.

return file_put_contents($path, $string);
}

protected function buildMigrationFile(array $queriesByVersion, $direction)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make all helper methods private

mikeSimonson added a commit that referenced this pull request Jun 29, 2015
@mikeSimonson mikeSimonson merged commit 70c5801 into doctrine:master Jun 29, 2015
@mikeSimonson
Copy link
Contributor

@neeckeloo Thanks

@neeckeloo neeckeloo deleted the feature/sql-file-writer-refactoring branch June 29, 2015 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants