Avoid uploading code coverage to Scrutinizer for HHVM and PHP 7 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7 and HHVM are not generating the code coverage data. Submitting to Scrutinizer in such case would notify it that there is no data, which would cancel the build in case it happens before another job succeeds and uploads the coverage.
4 tasks
stof
added a commit
that referenced
this pull request
Aug 2, 2015
Avoid uploading code coverage to Scrutinizer for HHVM and PHP 7
|
@stof Thanks, I was wondering were this issue was coming from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7 and HHVM are not generating the code coverage data. Submitting to Scrutinizer in such case would notify it that there is no data, which would cancel the build in case it happens before another job succeeds and uploads the coverage.
this will avoid having all builds being cancelled on Scrutinizer.