[DX] Formatted diffs #431
Merged
[DX] Formatted diffs #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padam87
force-pushed
the
sql-formatter
branch
from
747c580
to
fa2c729
Compare
|
Come to think of it, the composer suggestion might not be the best solution because of the phar release. Should I move it to require? |
| @@ -25,6 +25,9 @@ | |||
| "mockery/mockery": "^0.9.4", | |||
| "johnkary/phpunit-speedtrap": "~1.0@dev" | |||
| }, | |||
| "suggest": { | |||
| "jdorn/sql-formatter": "Allows to generate formatted SQL with the diff command." | |||
There was a problem hiding this comment.
you should also add a dev requirement to allow the tests to run
Padam87
force-pushed
the
sql-formatter
branch
from
fa2c729
to
83615e4
Compare
Padam87
force-pushed
the
sql-formatter
branch
from
83615e4
to
1bcb4ae
Compare
|
@Padam87 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be really convinient, especially for new projects.