Fix: Use class keyword #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@localheinz Yes, I would rather merge it after you get of the FQCN. |
localheinz
force-pushed
the
fix/class
branch
3 times, most recently
from
58ebdb9
to
1e92a99
Compare
|
Amended! |
|
About some of these imports: I personally prefer not to import everything, but instead import, let's say, parent namespace segments, what do you think? |
|
@localheinz I prefer to import everything to be explicit about the dependencies of the code |
|
@localheinz Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
classkeyword instead of referring to class names using string literalsFollows #393.
馃拋 Let me know if you prefer to get rid of FQCNs within this PR as well, otherwise I will follow up!