Add ConfigurationHelperInterface #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Nov 8, 2017
| @@ -88,7 +89,7 @@ protected function getMigrationConfiguration(InputInterface $input, OutputInterf | |||
| { | |||
| if ( ! $this->migrationConfiguration) { | |||
| if ($this->getHelperSet()->has('configuration') | |||
| && $this->getHelperSet()->get('configuration') instanceof ConfigurationHelper) { | |||
| && $this->getHelperSet()->get('configuration') instanceof ConfigurationHelperInterface) { | |||
| $configHelper = $this->getHelperSet()->get('configuration'); | |||
There was a problem hiding this comment.
If the configuration helper set exists, but it does not implement ConfigurationHelperInterface, could we throw an Exception instead? It seems like a misconfiguration - and it would silently fallback to the normal one.
There was a problem hiding this comment.
As much as I'd love to throw an exception, configuration is too generic to assume that there should only be a migrations configuration helper in there. An exception might be overkill, but we should think about how to make this more specific.
There was a problem hiding this comment.
Hmm, that makes sense, ok :)
weaverryan
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this problem a few days ago: needed to override the
ConfigurationHelperto be able to inject a custom finder implementation in DoctrineMigrationsBundle. Since the class is marked asinternal(and should probably befinalin 2.0), it makes sense adding an interface to allow people to supply their own configuration helper.