Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace invalid method call on Symfony 4 #578

Merged
merged 3 commits into from Dec 7, 2017
Merged

Replace invalid method call on Symfony 4 #578

merged 3 commits into from Dec 7, 2017

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Dec 7, 2017

This fixes a failing bug when running on Symfony 4: the setInputStream method in QuestionHelper has been removed; we now have to call setStream on the input itself.

@alcaeus alcaeus self-assigned this Dec 7, 2017
@alcaeus alcaeus merged commit 9ebd7a3 into doctrine:master Dec 7, 2017
@alcaeus alcaeus deleted the fix-failing-input-tests branch December 7, 2017 19:21
@mikeSimonson mikeSimonson added this to the 1.7 milestone Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alcaeus alcaeus

Labels
Improvement
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alcaeus @mikeSimonson