Throw only specialized package-only exceptions #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jun 5, 2018
|
|
||
| namespace Doctrine\Migrations\Finder\Exception; | ||
|
|
||
| interface FInderException |
greg0ire
reviewed
Jun 5, 2018
| return new self(sprintf( | ||
| 'Cannot load a migrations with the name "%s" because it is a reserved number by Doctrine Migrations.' | ||
| . PHP_EOL | ||
| . "It's used to revert all migrations including the first one.", |
There was a problem hiding this comment.
@greg0ire Some of the messages would indeed benefit from rewording, mind to send a PR? ;)
Majkl578
force-pushed
the
specialized-exceptions
branch
from
3922433
to
d9c1b0c
Compare
jwage
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stop throwing around SPL exceptions, only throw our own.
BC is kept through inheritance.