Major createMigrationTable() performance improvement #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration - the schema would be rebuilt on every request if the migration table already exists.
| @@ -477,7 +477,11 @@ public function createMigrationTable() | |||
|
|
|||
| return true; | |||
| } | |||
| return false; | |||
| else { | |||
There was a problem hiding this comment.
no need to use else here as the if returns (exactly as it was done previously)
|
Thank you @dtrethewey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the createMigrationTable() method in Configuration, the schema is re-created every time the method is called if the migration table already exists.
We were trying to run a fairly large set of migrations across multiple databases and this method is called many times, resulting in lots of createSchema() requests which really slows the migrations down.
Now it's only ever called once per database inside this method greatly improving performance.