Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator Template: Accept Properties #819

Closed
wants to merge 2 commits into from

Conversation

Finleth
Copy link

@Finleth Finleth commented May 10, 2019

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

My company and I are currently implementing this doctrine migrations library and have set it up such that we can pass a custom option to our custom generate command to use different default and content based off of the parameter given. However along these same lines we've found the need to pass in along default properties to the generated migration version.

This could be worked around (at my work I can just write my own Generator.php file that my custom generator command uses for now) but I thought this would be fairly simple to implement and could be beneficial for anybody else looking to use their own customizable templates.

Jeffrey Pau and others added 2 commits May 10, 2019 09:17
…d the logic to accept an input with which to replace the <properties> placeholder with.
@jwage
Copy link
Member

jwage commented May 10, 2019

This class is marked as internal. I am not sure how I feel about opening this up at the moment.

@Finleth
Copy link
Author

Finleth commented May 10, 2019

Would there be any other options for setting up default generated migrations with properties that can, through the use of either a custom command or any other command line options, take in a value for the properties?

EDIT - After playing around some more I found that a file can be set in the Configuration class which does exactly what I need, skipping the use of the and placeholders entirely. I appreciate you replying to my pull request. I will close it since this feature can be obtained without a work-around. Thanks!

@Finleth Finleth closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants