Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --write-sql command option description #997

Merged
merged 1 commit into from Jun 17, 2020
Merged

Fix --write-sql command option description #997

merged 1 commit into from Jun 17, 2020

Conversation

bobvandevijver
Copy link
Contributor

@bobvandevijver bobvandevijver commented Jun 16, 2020 •
edited

Q A
Type improvement
BC Break no

Summary

I believe this fixes a small oversight from f3c7942, which didn't update the command help descriptions with the new --write-sql behaviour.

Note: I'm not sure on the use of prepared, as I do not know at what stage the sql file is actually written.

@goetas goetas merged commit e9c54ed into doctrine:master Jun 17, 2020
@goetas
Copy link
Member

goetas commented Jun 17, 2020

thanks!

@bobvandevijver bobvandevijver deleted the patch-1 branch June 17, 2020 06:55
@goetas goetas added this to the 3.1.0 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobvandevijver @goetas