Merge pull request #1944 from createmultimedia/fix/generate-commands-…

…assert fix: replace string assertion with array assertion for $filter
doctrine · Jan 24, 2019 · 5d9b452 · 5d9b452
2 parents 24b12a0 + 41de69b
commit 5d9b452
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GenerateHydratorsCommand.php b/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GenerateHydratorsCommand.php
@@ -13,8 +13,8 @@
 use function assert;
 use function count;
 use function file_exists;
+use function is_array;
 use function is_dir;
-use function is_string;
 use function is_writable;
 use function mkdir;
 use function realpath;
@@ -58,7 +58,7 @@ protected function configure()
     protected function execute(Console\Input\InputInterface $input, Console\Output\OutputInterface $output)
     {
         $filter = $input->getOption('filter');
-        assert(is_string($filter));
+        assert(is_array($filter));
 
         $dm = $this->getHelper('documentManager')->getDocumentManager();
 

diff --git a/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GeneratePersistentCollectionsCommand.php b/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GeneratePersistentCollectionsCommand.php
@@ -13,8 +13,8 @@
 use function assert;
 use function count;
 use function file_exists;
+use function is_array;
 use function is_dir;
-use function is_string;
 use function is_writable;
 use function mkdir;
 use function realpath;
@@ -58,7 +58,7 @@ protected function configure()
     protected function execute(Console\Input\InputInterface $input, Console\Output\OutputInterface $output)
     {
         $filter = $input->getOption('filter');
-        assert(is_string($filter));
+        assert(is_array($filter));
 
         $dm = $this->getHelper('documentManager')->getDocumentManager();
 

diff --git a/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GenerateProxiesCommand.php b/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/GenerateProxiesCommand.php
@@ -16,6 +16,7 @@
 use function assert;
 use function count;
 use function file_exists;
+use function is_array;
 use function is_dir;
 use function is_string;
 use function is_writable;
@@ -56,7 +57,7 @@ protected function configure()
     protected function execute(Console\Input\InputInterface $input, Console\Output\OutputInterface $output)
     {
         $filter = $input->getOption('filter');
-        assert(is_string($filter));
+        assert(is_array($filter));
 
         /** @var DocumentManager $dm */
         $dm = $this->getHelper('documentManager')->getDocumentManager();