Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of deprecated "safe" option with "w" #655

Closed
jmikola opened this issue Aug 9, 2013 · 4 comments
Closed

Replace usage of deprecated "safe" option with "w" #655

jmikola opened this issue Aug 9, 2013 · 4 comments
Assignees
@jmikola
Milestone
1.0.0-BETA10

Comments

@jmikola
Copy link
Member

jmikola commented Aug 9, 2013

Driver 1.5+ formally deprecates use of the "safe" option for write concerns. Code should be changed to use "w".
@ghost ghost assigned jmikola Aug 9, 2013
@ghost
Copy link

ghost commented Sep 5, 2013

Hello,

I have the same problem.

Have a good day

@Engerim
Copy link
Contributor

Engerim commented Apr 7, 2014

Hello,

To fix the problem, it is only a modifcation in the SchemaManager Line 239? If this is so, I can provide a pull request.

@jmikola
Copy link
Member Author

jmikola commented Apr 9, 2014

@Engerim: This isn't specific to SchemaManager. I believe it's also a concern for the configuration options, which specifies defaults used for write ops unrelated to index management, too.

@jmikola jmikola removed this from the 1.0.0-BETA10 milestone Apr 9, 2014
@jmikola
Copy link
Member Author

jmikola commented Apr 9, 2014

This should be fixed by #848.

jmikola added a commit that referenced this issue Apr 9, 2014
@jmikola
Use "w" instead of "safe" for write option with driver 1.3+
5d90c14 
Doctrine MongoDB already converts "safe" to "w" (doctrine/mongodb@c7b6ef9) but it's wise to use the correct option anyway.

Fixes #655.
jmikola added a commit that referenced this issue Apr 9, 2014
@jmikola
Set default "w" or "safe" option when creating indexes
334e6cd 
Depending on the driver version, "w" or "safe" should be set by default. doctrine/mongodb#168 may make this unnecessary, but there's no reason ODM cannot be explicit.

Fixes #655.
@jmikola jmikola added this to the 1.0.0-BETA10 milestone Apr 9, 2014
jmikola added a commit that referenced this issue Apr 10, 2014
@jmikola
Set default "w" or "safe" option when creating indexes
deb6a38 
Depending on the driver version, "w" or "safe" should be set by default. doctrine/mongodb#168 may make this unnecessary, but there's no reason ODM cannot be explicit.

Fixes #655.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmikola jmikola

Labels
None yet
Projects
None yet
Milestone
1.0.0-BETA10
Development

No branches or pull requests
2 participants
@jmikola @Engerim