-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0][RFC] Add get to default repository #1613
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[2.0] Bump PHP to 7.0
[2.0] Remove deprecated annotations
[2.0] Remove simple references leftovers
[2.0] Use storeAs=dbRef as the new default setting for references
malarzm
force-pushed
the
add-get-to-repository
branch
from
June 23, 2017 19:56
fb7a957
to
fda27ae
Compare
As mentioned in IRC, I see a few issues with the method:
Considering this, I'm 👎 on adding this. |
alcaeus
force-pushed
the
odm-ng
branch
2 times, most recently
from
November 3, 2017 06:00
f07e68d
to
fa8edc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I have realized that most of my custom repositories are beginning with
get
method which looks just like the one I have here. So how about adding it to core? If we say "yes" then here's still few things to do like:ObjectRepository
occurrences to newRepository
odm-ng
atop currentmaster
Also since it's for 2.0 we may consider moving Repository-related classes around as we got ourselves "Repository" namespace just before 1.0, but that will mean more things to fix for users when upgrading.