Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DocumentManager::getHydratorFactory() return type #1638

Closed
wants to merge 1 commit into from
Closed

Fix DocumentManager::getHydratorFactory() return type #1638

wants to merge 1 commit into from

Conversation

olvlvl
Copy link
Contributor

@olvlvl olvlvl commented Sep 2, 2017

Hi,

DocumentManager::getHydratorFactory() return type is wrong, see

mongodb-odm/lib/Doctrine/ODM/MongoDB/DocumentManager.php

Line 84 in f7379e4

* @var HydratorFactory

@malarzm malarzm added the Task label Sep 4, 2017
@malarzm malarzm added this to the 1.1.7 milestone Sep 4, 2017
@malarzm
Copy link
Member

malarzm commented Sep 4, 2017

@olvlvl thanks a bunch for the PR! I'll merge it manually later as I need to re-target this for 1.1.x branch (unless you mind doing that)

@olvlvl olvlvl mentioned this pull request Sep 4, 2017
Merged
@olvlvl
Copy link
Contributor Author

olvlvl commented Sep 4, 2017

@malarzm Is that what you need? #1642

@malarzm
Copy link
Member

malarzm commented Sep 4, 2017

Exactly, thanks, I'll close this one then 👍

@malarzm malarzm closed this Sep 4, 2017
@malarzm malarzm removed this from the 1.1.7 milestone Sep 4, 2017
@olvlvl olvlvl deleted the olvlvl-fix-return-type branch September 4, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olvlvl @malarzm