Fix Match::$query type #1640
Fix Match::$query type #1640
Conversation
|
|
||
| /** | ||
| * Fluent interface for building aggregation pipelines. | ||
| */ | ||
| class Match extends BaseStage\Match | ||
| { | ||
| /** | ||
| * @var Expr | ||
| */ | ||
| protected $query; |
There was a problem hiding this comment.
This does not need to be redeclared just to change a typehint. Use the property annotation on the class if you want to fix that.
There was a problem hiding this comment.
The @property annotation is for public properties, this one is protected.
There was a problem hiding this comment.
Oh. I forgot, sorry about that. In that case, I’d much rather just leave this out. It’s a non-issue at the docs level, and we’re changing the API for 2.0 anyways: the base classes of the query and aggregation builders will move into this project. doctrine/mongodb won’t be adapted for ext-mongodb (its job is done by mongodb/mongodb now) and there’s no point bothering with that two-level API. It’s caused enough problems as it is.
There was a problem hiding this comment.
Thanks for the detailed explanation.
Hi,
Doctrine\MongoDB\Query\Exprdoesn't have the methodsreferences()orincludesReferenceTo(), butDoctrine\ODM\MongoDB\Query\Exprdoes.