Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated PHPUnit assertions #1820

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Use dedicated PHPUnit assertions #1820

merged 1 commit into from
Jul 27, 2018

Conversation

carusogabriel
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues -

@alcaeus alcaeus self-requested a review July 6, 2018 14:30
@alcaeus
Copy link
Member

alcaeus commented Jul 13, 2018

@carusogabriel can you fix the phpcs issue?

FILE: tests/Doctrine/ODM/MongoDB/Tests/Functional/CustomIdTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Type count is not used in this file.

@carusogabriel
Copy link
Contributor Author

@alcaeus Should be RTM :)

@alcaeus alcaeus merged commit 757bdb6 into doctrine:master Jul 27, 2018
@alcaeus
Copy link
Member

alcaeus commented Jul 27, 2018

Thanks @carusogabriel!

@alcaeus alcaeus added this to the 2.0.0 milestone Jul 27, 2018
@alcaeus alcaeus added the Task label Jul 27, 2018
@alcaeus alcaeus self-assigned this Jul 27, 2018
@carusogabriel carusogabriel deleted the dedicated-phpunit-assertions branch July 27, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @alcaeus