Fix type hint: createDocument(array $result) #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olvlvl
force-pushed
the
olvlvl-type-hint
branch
from
674a888
to
c540046
Compare
Merged
|
Cherry-picked into #1871. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found out the hard way that the implementation only works if the MongoDB client is configured to convert
rootanddocumenttypes to array. Therefore, I believe the type hint of the$resultparameter of thecreateDocument()method should be?arrayinstead ofobject.I also added a commit that moves the type check to the caller method as to avoid an necessary method call. This change also allows narrowing the type hint of the
$resultparameter toarray.