Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fieldName with field-name #1891

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix fieldName with field-name #1891

merged 1 commit into from
Nov 13, 2018

Conversation

olvlvl
Copy link
Contributor

@olvlvl olvlvl commented Nov 13, 2018

Q A
Type bug
BC Break no

Summary

Fix some typos in the documentation.

@olvlvl
Fix fieldName with field-name
7d9a61e 
Also, terminate the `key` markup.
alcaeus
alcaeus approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olvlvl!

@alcaeus alcaeus self-assigned this Nov 13, 2018
@alcaeus alcaeus added this to To Do in ODM 2.0 via automation Nov 13, 2018
@alcaeus alcaeus added this to the 2.0.0 milestone Nov 13, 2018
@malarzm malarzm merged commit 9625a89 into doctrine:master Nov 13, 2018
ODM 2.0 automation moved this from To Do to Done Nov 13, 2018
@malarzm
Copy link
Member

malarzm commented Nov 13, 2018

Thanks @olvlvl!

@olvlvl olvlvl deleted the patch-1 branch November 13, 2018 18:40
@alcaeus alcaeus added this to 2.0 in Roadmap Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Documentation
Projects
No open projects
ODM 2.0
  
Done
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olvlvl @malarzm @alcaeus