New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark classes as final #1984
Mark classes as final #1984
Conversation
With 1.3.x now being merged down into master, we no longer prepare separate pull requests to prepare deprecations. The course of action in this case would be to create a pull request to 1.3.x that marks the classes in question as Once the PR to 1.3.x has been merged and the branch merged into master, this PR can be rebased to drop the |
#2008 was merged into 1.3.x and further on to master, so this can be rebased. @malarzm you can remove changes to |
56aaae9
to
5773408
Compare
4471237
to
eee3de8
Compare
eee3de8
to
2f59bce
Compare
Several classes are now marked as final. Some things I was considering:
By the way I've removed two unused mock classes and a test that was testing nothing (interesting) and allowed me to make
ClassMetadataFactory
final