-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to doctrine/cs v6 #2014
Merged
Merged
Update to doctrine/cs v6 #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
commented
Apr 21, 2019
lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php
Show resolved
Hide resolved
carusogabriel
force-pushed
the
chore/coding-standard
branch
from
April 21, 2019 07:55
d5a47c6
to
7978a64
Compare
malarzm
reviewed
Apr 21, 2019
carusogabriel
force-pushed
the
chore/coding-standard
branch
2 times, most recently
from
April 26, 2019 02:07
4ad985c
to
134d982
Compare
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
I'll come back to this during the week :) |
carusogabriel
force-pushed
the
chore/coding-standard
branch
2 times, most recently
from
July 9, 2019 20:46
9cd7876
to
3a9131f
Compare
carusogabriel
force-pushed
the
chore/coding-standard
branch
2 times, most recently
from
July 9, 2019 21:05
a551d7c
to
857559a
Compare
malarzm
approved these changes
Jul 11, 2019
@carusogabriel could you please resolve the conflicts? |
For all the new rules, please see https://github.com/doctrine/coding-standard/releases/tag/6.0.0.
carusogabriel
force-pushed
the
chore/coding-standard
branch
from
July 11, 2019 10:24
857559a
to
5ac9e08
Compare
@malarzm Done 👍 |
alcaeus
approved these changes
Jul 12, 2019
Thanks Gabriel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the latest version of https://github.com/doctrine/coding-standard.