Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move custom type to a separate chapter #2081

Merged
merged 2 commits into from Oct 8, 2019
Merged

Move custom type to a separate chapter #2081

merged 2 commits into from Oct 8, 2019

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Oct 7, 2019

Closes #1444 and closes #1607

@malarzm malarzm changed the base branch from master to 2.0.x October 7, 2019 21:25
@malarzm malarzm changed the base branch from 2.0.x to master October 7, 2019 21:25
alcaeus
alcaeus approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the small grammar fix applied.

docs/en/reference/basic-mapping.rst Outdated Show resolved Hide resolved
@malarzm @alcaeus
Update docs/en/reference/basic-mapping.rst
13d5a3c 
Co-Authored-By: Andreas Braun <alcaeus@users.noreply.github.com>
@alcaeus alcaeus added this to the 2.1.0 milestone Oct 8, 2019
@alcaeus alcaeus added this to In progress in ODM 2.1 via automation Oct 8, 2019
@alcaeus alcaeus added this to 2.1 in Roadmap Oct 8, 2019
@alcaeus alcaeus self-assigned this Oct 8, 2019
@alcaeus
Copy link
Member

alcaeus commented Oct 8, 2019

Thanks @malarzm!

@alcaeus alcaeus merged commit b42750d into doctrine:master Oct 8, 2019
ODM 2.1 automation moved this from In progress to Done Oct 8, 2019
@malarzm malarzm deleted the move-custom-types-chapter branch May 28, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Documentation
Projects
No open projects
ODM 2.1
  
Done
Roadmap
2.1 (unsupported)
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Document ClosureToPHP trait Revisit Custom Mapping Types docs
2 participants
@malarzm @alcaeus