Cast also-load xml attribute to string #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yaml driver returns different results then the xml driver for also-load attribute so we need to create a new unit test.
|
Related to #2084 |
alcaeus
requested changes
Oct 14, 2019
tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/XmlDriverTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/XmlDriverTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/XmlDriverTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/XmlDriverTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/XmlDriverTest.php
Outdated
Show resolved
Hide resolved
added 2 commits
October 14, 2019 14:52
…tring for class name
…ng unit tests Let composer autoloader handle the loading of these files.
|
Hi @alcaeus, anything other changes need ed for this pull request or is it all ok? |
alcaeus
approved these changes
Nov 5, 2019
|
Thanks @SSHVersionControl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need to cast also-xml to string before calling explode as it is a SimpleXmlElement object otherwise a fatal error is thrown