Fix hanging upload when not specifying chunk size #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Oct 30, 2019
lib/Doctrine/ODM/MongoDB/Repository/DefaultGridFSRepository.php
Outdated
Show resolved
Hide resolved
malarzm
approved these changes
Oct 30, 2019
|
Merging - build was stable but travis-ci somehow didn't report this to GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmikola The issue is caused by
mongodb/mongodbusingissetchecks for options. When passing anulloption, it will not be validated (asissetreturnsfalse) but still assigned. Thenullvalue is then interpreted as0in various places, leading to an endless loop of reading 0 bytes and not inserting an empty chunk. This is something we may want to address, so I've created PHPLIB-494 to track this.