Remove unneceesary internal designations #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
👍 If you think none of these are worth keeping. If you think otherwise, wrapping those with curly brackets seems the way to go according to https://docs.phpdoc.org/references/phpdoc/tags/internal.html (one opening curly bracket, 2 closing, that's quite weird)
malarzm
approved these changes
Nov 25, 2019
|
Thanks for taking the time to finally remove these comments :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes a few
@internaldesignations for methods that aren't really internal, but where the comment was used to leave notes that shouldn't be exposed in an API documentation.