Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for date_immutable type #2127

Merged
merged 1 commit into from Dec 2, 2019
Merged

More tests for date_immutable type #2127

merged 1 commit into from Dec 2, 2019

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Nov 29, 2019

Q A
Type improvement
BC Break no
Fixed issues n/a

Summary

Few tests I've missed while originally working on date_immutable

@malarzm malarzm added the Task label Nov 29, 2019
@malarzm malarzm added this to In progress in ODM 2.1 via automation Nov 29, 2019
@malarzm malarzm added this to the 2.1.0 milestone Nov 29, 2019
alcaeus
alcaeus reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs disapproves ;)

tests/Doctrine/ODM/MongoDB/Tests/Types/TypeTest.php Outdated Show resolved Hide resolved
tests/Doctrine/ODM/MongoDB/Tests/Types/TypeTest.php Outdated Show resolved Hide resolved
@malarzm
Copy link
Member Author

malarzm commented Dec 2, 2019

This has been the worst code sniff in the history of code sniffs, maybe ever

ODM 2.1 automation moved this from In progress to Reviewer approved Dec 2, 2019
alcaeus
alcaeus approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with squashed commits.

@malarzm malarzm force-pushed the missing-test-for-date-immutable-mm branch from 63b2387 to ef4d79f Compare December 2, 2019 21:28
@malarzm malarzm merged commit 739a87e into doctrine:master Dec 2, 2019
ODM 2.1 automation moved this from Reviewer approved to Done Dec 2, 2019
@malarzm malarzm deleted the missing-test-for-date-immutable-mm branch December 2, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Task
Projects
No open projects
ODM 2.1
  
Done
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malarzm @alcaeus