Add Decimal128 type #2128
Merged
Add Decimal128 type #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
force-pushed
the
decimal128-type
branch
from
f8960d8
to
137ca5d
Compare
|
Please ignore CS issues for now, there's something fishy going on with my local instance of |
alcaeus
requested changes
Dec 5, 2019
malarzm
force-pushed
the
decimal128-type
branch
7 times, most recently
from
f011128
to
88a57bd
Compare
alcaeus
reviewed
Dec 17, 2019
There was a problem hiding this comment.
Just a couple of minor things, rest LGTM 👍
Can you create an issue to track the interface for version types? (see #2128 (comment))
| private function typeRequirementsAreMet(string $type) : void | ||
| { | ||
| if ($type === Type::DECIMAL128 && ! extension_loaded('bcmath')) { | ||
| throw MappingException::typeRequirementsNotFulfilled(Type::DECIMAL128, 'ext-bcmath is missing'); |
There was a problem hiding this comment.
Adding the field and class names to the exception message will make it easier for users to spot which piece of their code is causing these errors.
alcaeus
approved these changes
May 6, 2020
|
Thanks Maciej! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per title, again ;)